--- Log opened Wed Feb 06 00:00:16 2019 |
00:50 | | celmin|away is now known as celticminstrel |
01:09 | | Kindamoody is now known as Kindamoody[zZz] |
01:39 | | Vornicus [Vorn@ServerAdministrator.Nightstar.Net] has quit [Connection closed] |
02:01 | | Degi [Degi@Nightstar-b8srem.dyn.telefonica.de] has quit [Connection closed] |
02:03 | | macdjord|slep is now known as macdjord |
02:44 | | * iospace hats McMartin and ToxicFrog |
03:12 | <@macdjord> | simon_: I mean, I can think of a few cases where 'check_logic_helper' would be a perfectly logical and obvious name. A parser might have module for evaluating boolean expressions called 'logic_helper', in which case 'check_logic_helper' is a unit test for it. Or you might have a checksumming function called 'check_logic', and 'check_logic_helper' is a helper function for that. Or you might have some sort of MVC setup where the buisness |
03:12 | <@macdjord> | logic is in a unit called 'logic', and 'check_logic_helper' is either the test of the helper or the helper for the test. |
04:00 | | Emmy [Emmy@Nightstar-9p7hb1.direct-adsl.nl] has joined #code |
04:16 | | Emmy [Emmy@Nightstar-9p7hb1.direct-adsl.nl] has quit [Ping timeout: 121 seconds] |
04:21 | | * iospace eyes this python error |
04:21 | <@iospace> | Traceback (most recent call last): |
04:21 | <@iospace> | File "F:\Users\<LOLNO>\Documents\weather\Python-Weather\weather.py", line 108, in <module> |
04:21 | <@iospace> | NWS.display_alerts(alerts["features"]) |
04:21 | <@iospace> | AttributeError: 'bool' object has no attribute 'display_alerts' |
04:21 | <@iospace> | I'm not returning a bool |
04:21 | <@iospace> | I'M RETURNING NONE |
04:27 | | * iospace punts Python |
04:28 | <@iospace> | this is why I like C/C++, you know what you're getting back |
04:37 | <@iospace> | even a fucntion like this |
04:37 | <@iospace> | def test_function(): |
04:37 | <@iospace> | print("THIS IS A TEST") |
04:37 | <@iospace> | return |
04:37 | <@iospace> | same error |
04:38 | <@Alek> | uhh. I wanna say maybe there's some code elsewhere in the file that affects return to make it seem boolean to the interpreter? |
04:39 | <@Alek> | maybe you accidentally converted it by pushing an attribute to it? |
04:39 | <&[R]> | iospace: what python version |
04:39 | <@iospace> | 3.7.2 |
04:40 | <&[R]> | Both my 2 and 3 interpreters have that return NoneType and it behaves like None properly |
04:42 | <@iospace> | hmm.. |
04:44 | <@iospace> | I commented out the other functions in that |
04:44 | <@iospace> | except for test_function |
04:44 | <@iospace> | same error o_O |
04:45 | <@iospace> | so I have no damn clue why it's being fussy |
04:45 | <@iospace> | and importing a file that is solely test_function() doesn't have the error |
04:54 | | Derakon[AFK] is now known as Derakon |
05:10 | | himi [sjjf@Nightstar-1drtbs.anu.edu.au] has quit [Ping timeout: 121 seconds] |
05:12 | | Derakon is now known as Derakon[AFK] |
05:33 | <@macdjord> | iospace: If you change 'return' to an explicit 'return None', does that have any effect? (It shouldn't.) |
05:34 | <@macdjord> | Are there any decorators on the function definition which might be mangling the return? |
05:34 | <@macdjord> | Try replacing the 'return' with 'raise Exception()' and take a look at the call stack. |
05:36 | <@macdjord> | Also 'None' doesn't have a 'display_alerts' member /either/, so the line you've given is still going to fail. |
05:59 | | celticminstrel is now known as celmin|sleep |
06:23 | < simon_> | =head2 auto_setup |
06:23 | < simon_> | This method tries to figure out what fields to fill out with the data from the attached objects... |
06:24 | < simon_> | I'm pretty sure it does something concrete, and that 'fields' refers to some kind of databased properties of a specific entity called Ticket, and that 'attached objects' are MIME parts of a sent email. |
06:25 | < simon_> | but it might as well have said "Takes as input data, performs a transformation of this data and returns output data." |
06:26 | < simon_> | iospace, also, no, the file isn't commented. that's what I'm doing. :) I'm asked to review changes to it, and since I don't understand what the functions I'm reviewing do, I'm submitting a review for those who submitted a review with an attempt to say what they do. |
06:28 | < simon_> | macdjord, and yes, there are cases where 'logic' is a perfectly valid thing to call something. but I'm pretty sure this kind of logic simply refers to "the business logic of this part of the application". |
06:28 | < simon_> | so they could have called it 'code'. |
06:28 | < simon_> | and it would still be right. |
07:28 | | himi [sjjf@Nightstar-v37cpe.internode.on.net] has joined #code |
07:28 | | mode/#code [+o himi] by ChanServ |
08:03 | | Kindamoody[zZz] is now known as Kindamoody |
09:39 | | Vornicus [Vorn@ServerAdministrator.Nightstar.Net] has joined #code |
09:39 | | mode/#code [+qo Vornicus Vornicus] by ChanServ |
10:47 | | catalyst [Jessikat@Nightstar-5dv16h.cable.virginm.net] has joined #code |
11:53 | | Degi [Degi@Nightstar-gp1ore.dyn.telefonica.de] has joined #code |
13:31 | | celmin|sleep is now known as celmin|away |
14:57 | | Kindamoody is now known as Kindamoody|afk |
15:38 | | Degi [Degi@Nightstar-gp1ore.dyn.telefonica.de] has quit [Connection closed] |
16:29 | <@TheWatcher> | I. Fucking. Hate. Ruby. |
16:34 | <~Vornicus> | a very common sentiment |
16:38 | < catalyst> | a gem of a statement |
16:39 | | * TheWatcher idly sets catalyst on fire |
16:40 | <@TheWatcher> | I've just spent the last 4 hours and 40 minutes upgrading gitlab, 90% of the problems thanks to ruby |
16:40 | | * catalyst monkeypatches TheWatcher's integer primitives |
16:46 | | Emmy [Emmy@Nightstar-9p7hb1.direct-adsl.nl] has joined #code |
19:53 | | himi [sjjf@Nightstar-v37cpe.internode.on.net] has quit [Ping timeout: 121 seconds] |
20:27 | <&McMartin> | Oh hey, it is a catalyst! |
20:28 | < catalyst> | sup |
20:28 | <&McMartin> | Wishing lunch were here :( |
20:29 | <&McMartin> | Also, I've been playing https://youtu.be/ldJr6nUDqAs lately, and it's kind of interesting as a sort of modern take on PS1 graphics, or possibly Rez graphics. |
20:30 | <&McMartin> | (I'm nearly done with the game, though, and tragically it does not seem to add up to much) |
20:30 | | * McMartin also eyes Ars Technica's headlin writers |
20:30 | <&McMartin> | "With experimental “Never slow mode,” Chrome tries to stop Web devs making it slow" |
20:30 | <&McMartin> | Subhed: "There's just one small downside: It breaks the Web." |
20:30 | < catalyst> | oo, that looks pretty |
20:31 | < catalyst> | It looks most like Journey to me |
20:31 | <&McMartin> | It's got some pretty bits, but it's a hard game to go exploring in because it's both small and very sparse, and the gameplay takes place off the main world map |
20:32 | <&McMartin> | And so far no puzzle has been more complex than "stand on this button, then go stand on this other button that just started glowing" and there's very little game left... |
20:33 | <&McMartin> | I think "combatless Zeldalike" is going to need a little more than that to really take off |
20:33 | <&McMartin> | (But man they so obviously looked at parts of Skyward Sword's opening third or so and said to themselves 'we can so do this better') |
20:34 | <&McMartin> | But yes, my big takeaways are "If this is what PS1/N64 nostalgia are going to look like, I'm OK with that" and "catalyst should see this" |
20:42 | <&ToxicFrog> | I picked it up mostly because with the current Steam sale it was basically free and it looked like something Alex might like |
20:42 | | Kindamoody|afk is now known as Kindamoody |
20:42 | <&ToxicFrog> | And she does indeed appear to like it |
20:49 | | JustBob [justbob@Nightstar.Customer.Dissatisfaction.Administrator] has quit [Ping timeout: 121 seconds] |
20:49 | | JustBob [justbob@ServerAdministrator.Nightstar.Net] has joined #code |
20:49 | | mode/#code [+o JustBob] by ChanServ |
21:02 | | * McMartin gets word 'lunch should be here by 2' |
21:02 | <&McMartin> | Now I'm remembering why I don't go in on lunch orders so often >_< |
21:56 | | himi [sjjf@Nightstar-1drtbs.anu.edu.au] has joined #code |
21:57 | | mode/#code [+o himi] by ChanServ |
22:49 | | Emmy [Emmy@Nightstar-9p7hb1.direct-adsl.nl] has quit [Ping timeout: 121 seconds] |
22:51 | | Degi [Degi@Nightstar-gp1ore.dyn.telefonica.de] has joined #code |
--- Log closed Thu Feb 07 00:00:17 2019 |